search

jiaozi158 / UnitySSGIURP

Screen Space Global Illumination for Unity URP (Universal Render Pipeline).
MIT License
117 stars 12 forks source link

Is it working? #4

Open Tufis16 opened 3 months ago

Tufis16 commented 3 months ago

I tested on Unity 2022.3.22 and added in global volume and urp setting but nothing changed. Also changed forward/forward+/deffered not working.

jiaozi158 commented 3 months ago

Hi, do you have SSGI enabled in the volume override? SSGI_Volume_Override

jiaozi158 commented 3 months ago

By the way, I suggest upgrading to a higher (patch) version of Unity Editor before installing this package, such as 2022.3.35f1.

There was a bug in older versions of URP related to the render queue, and I don't have time to find out which version it was fixed in.

Tufis16 commented 3 months ago

Yes it's enabled. I will test your recommended version and after i will tell the results. Thanks.

Tufis16 commented 3 months ago

Yeah i tested in clean Unity 2022.3.38 urp project and same. Can't see any diffrence. And yes everything attached and enabled.

jiaozi158 commented 3 months ago

That's strange. Does the camera's active URP renderer have SSGI (renderer feature)?

Camera's renderer in use: Camera_Renderer URP renderer asset: URP Renderer

Tufis16 commented 3 months ago

I tried but no.

jiaozi158 commented 3 months ago

Could you provide a small project (ex. the empty project you created) so that I can reproduce the problem?

Project Folder Thank you very much!

Tufis16 commented 2 months ago

Still same, i read all your replies. I follow this steps and more: 1- Download this "https://github.com/jiaozi158/UnitySSGIURP.git" with github "or just downloaded with zip" 2- Drag and dropped to project 3- Added to renderer feature and enabled 4- Added to Global Volume and enabled 5- Checked rendering pipelines "from cameras or graphics settings" no changes anything.

This is project: https://we.tl/t-zCMD0JKSms

jiaozi158 commented 2 months ago

Hi, could you try again (the latest version) and see if the issue is resolved?

I downloaded the project you provided and found that it seems to be the same problem mentioned in #5.

Tufis16 commented 2 months ago

YES IT'S WORKING NOW THANKS!!!!

On Wed, Jul 31, 2024 at 9:26 PM jiaozi158 @.***> wrote:

Hi, could you try again (the latest version) and see if the issue is resolved?

I downloaded the project you provided and found that it seems to be the same problem mentioned in #5 https://github.com/jiaozi158/UnitySSGIURP/issues/5.

— Reply to this email directly, view it on GitHub https://github.com/jiaozi158/UnitySSGIURP/issues/4#issuecomment-2261151938, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4HSLJKQIRKNDJ5VCOB4HLZPET53AVCNFSM6AAAAABLFWIML2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRRGE2TCOJTHA . You are receiving this because you authored the thread.Message ID: @.***>

-- Co-Founder && Head of Game Design at BYTEROP x GAMEVATO

Tufis16 commented 2 months ago

I think intensity is too low. Max value is 0.95. How can we make more saturated or high intensity?

jiaozi158 commented 2 months ago

How can we make more saturated or high intensity?

Hi, the "0.95" value controls the intensity of temporal accumulation.

I think you're looking for the "Indirect Diffuse Lighting Multiplier". Multiplier

Tufis16 commented 2 months ago

Yes i mean this! but it shows after setting "All Visible" "Show All Addinational Setting Properties"

Missing

All visible

jiaozi158 commented 2 months ago

Thanks for reminding!

I don't think it should be an additional property, so I'll change that in the next update.