search

jiasheng59 / pe

0 stars 0 forks source link

UML diagram contains too much unnecessary low level details #19

Open jiasheng59 opened 1 year ago

jiasheng59 commented 1 year ago

This particular class diagram contains a lot of details that do not add value to the implementation high level idea described in the paragraph below. Moreover its size is too small as compared to other uml diagram in this document image.png

nus-pe-bot commented 1 year ago

Team's Response

The UI Class diagram is important to our implementation of ModCheck as there are two different windows being shown and only a few classes were added to the original documentation to showcase the classes used for LoginWindow which is WelcomeSection, LoadingSection, CreatePasswordSection and DefaultLoginSection.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It should be abstracted out as a separate class diagram should you think it's important. Dumping every single class relevant in a single diagram just makes it unreadable to reader