nus-se-bot
commented
3 years ago Team's Response
The probability of two suppliers or warehouses with the same name will be very low. If there are indeed two suppliers or warehouses with the same name, the users should use other means (e.g. using parentheses in the supplier or warehouse name when adding the supplier or warehouse). On the other hand, it should be allowed for two suppliers or warehouses with different names yet have the same phone number, email or address as the same person could be in charge/managing several warehouses and suppliers).
Our team have discussed this issue during the development of CLI-nic and here is the link to the issue on Github of our discussion: #149
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I understand your position that two suppliers/warehouses can have the same phone number/email as the same person can be in charge of managing different suppliers/warehourses. However, I still believe that it is a feature flaw that users are not allowed to input the same name despite having different phone number/email/address. This is because we can have 2 warehouses owned by the same company but at different locations, which means that they will have the same name under the "name" field but different addresses in the address field. (E.g. Taking an example from the hotel industry, we have 6 holiday day inn hotels Singapore. It will be inefficient for the users to input additional parenthesis in the name field so that the input can be accepted.) Hence, I believe that this is a flaw that may cause some inconvenience for users as they are unable to add warehouse or suppliers with the same name and are required to manually input additional text to differentiate the names. One suggestion will be to perhaps allow the users to input the same name as long as their phone/email/address are different to show that it is an unique warehouse/supplier. Having different names with the same phone number/email/address can still be allowed as well as stated in the team's response.
:question: Issue severity
Team chose [severity.Low]
Originally [severity.High]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Commad:
add ct/s n/hi p/0123 e/asd@comadd ct/s n/hi p/01234 e/asda@comExpected: Input to be accepted, since 2 suppliers can have the same name, but different email/number.
Actual: Error message thrown indicating supplier is in CLI-nic already. I believe this is a feature flaw as 2 suppliers can have the same name. Maybe shoud add in mobile number/email for identity checks.