search

jiaweiteo / pe

0 stars 0 forks source link

Feature flaw: Same number/email allowed for 2 different suppliers #6

Open jiaweiteo opened 3 years ago

jiaweiteo commented 3 years ago

Command: add ct/s n/hi2 p/0123 e/asda@com add ct/s n/hi3 p/0123 e/asda@com

Expected: Second command rejected since we have a previous supplier with the same number and email.

Actual: Input accepted. Feature flaw as it is quite impossible for 2 different person to have the same email and number.

image.png

nus-se-bot commented 3 years ago

Team's Response

Firstly, I think the original AB3 has a same implementation on the address & phone parsing. Secondly, we can consider a special case where the user wants to manage 2 warehouses (1 for drugs and 1 for miscellaneous medical supply) that are in the same place separately. In this case, he may have to use the same phone number/address record on 2 different entries. With that consideration in mind, our team decided to allow duplicate phone number and addresses.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]