jiaxiangc / ComfyUI-ResAdapter

ComfyUI extension for ResAdapter.
Apache License 2.0
273 stars 8 forks source link

Edit: Resolved #1

Closed LastTargaryen closed 4 months ago

LastTargaryen commented 4 months ago

If you're delayed from releasing code, or don't plan on releasing code,

DON'T OPEN A REPOSITORY. It's EXTREMELY ABUSIVE TO GITHUB'S PURPOSE.

GITHUB IS NOT YOUR FREE ADVERTISEMENT PLATFORM.

NO ONE ENJOYS SEEING AN EMPTY REPOSITORY THAT IS LABELED AS CONTAINING IMPORTANT TECHNOLOGY

THANKS

jiaxiangc commented 4 months ago

@LastTargaryen Hello, I will release the code this month, please be patient. I have no intention of advertising on Github.

jiaxiangc commented 4 months ago

I will notify you as soon as possible after I release the code. Thank you for your support. At the same time, I will also support ResAdapter in WebUI.

jiaxiangc commented 4 months ago

@LastTargaryen The reason I delayed releasing the ComfyUI code is that we need to prioritize promoting the code internally before releasing it. Please wait.

LastTargaryen commented 4 months ago

@LastTargaryen The reason I delayed releasing the ComfyUI code is that we need to prioritize promoting the code internally before releasing it. Please wait.

I appreciate that you're trying to provide me / the community with a legitimate response.

...but what in the world does "we need to prioritize promoting the code internally" mean? I wasn't asking for reasons, nor was I demanding an explanation at all. But you've offered an explanation, so this is me asking you,

What do you mean by that?

jiaxiangc commented 4 months ago

@LastTargaryen We will open source it as soon as possible, but we need to prioritize using ComfyUI-ResAdapter within our company.

LastTargaryen commented 4 months ago

Thank you for the direct response. We very much await the validation of this repository. As it stands now, this repository is currently being used as a place-holding announcement for material that that you claim is authored by you and completed, but is conspicuously withheld due to corporate interest. I just want to clarify that the philosophy of open source does not include consideration of corporate interest prior to complete, costless release. It is true that the definitions of such philosophies have gray areas--it may be wise for you to be aware of that, as well.

Because no one in this community sees your repository and thinks "oh wow, I can't wait for this giant company to do whatever it's going to do with this product so we can get whatever they don't determine is profitable!"

Thank you for your hard work in creating this...but you could have just waited to create the repository when you were certain that you are permitted to release the code.

jiaxiangc commented 4 months ago

I think you are absolutely right. I will pay attention to it in future open source. At the same time, I will release the code as soon as possible, thank you for your suggestions.

jiaxiangc commented 3 months ago

@LastTargaryen We have released the code.