jiayihu / ng-animate

🌙 A collection of cool, reusable and flexible animations for Angular 14+
https://jiayihu.github.io/ng-animate/
MIT License
720 stars 72 forks source link

Add missing animations from v4 #52

Closed TheDelta closed 2 years ago

TheDelta commented 2 years ago

Add missing v4 animations (#25), also:

The update of the examples was made to easier handle future animations / updates in the future. Hopefully this is okay.

jiayihu commented 2 years ago

Hi, thanks for the PR! I don't see any change in the dependency, does this mean that the library is still valid with latest Angular? It has been years since I've used Angular, I'll need some time to catch up on the basics and review the PR 😄

TheDelta commented 2 years ago

as been years since I've used Angular

Yeah I figured already by reading other issues :)

I haven't included any changes of package dependencies yet, to isolate any issues. It works fine for Angular 13, but is complaining about missing ivy distribution (see #46)

I would do a version bump to ng13 and add the missing parts for the ivy distribution in another PR, but I assume this also means that ng13 is minimum version then. (haven't really done libraries in angular yet, well despite using them)