search

jiayihu / ng-animate

🌙 A collection of cool, reusable and flexible animations for Angular 14+
https://jiayihu.github.io/ng-animate/
MIT License
721 stars 72 forks source link

Upgrade to Angular 14 #53

Closed TheDelta closed 2 years ago

TheDelta commented 2 years ago

Also probably fixes all DependaBot issues and the PR can be removed.

I also bumped the version to 14.0.0, guess it makes sense to keep it in sync with angular versioning.

PR is based on my previous PR #52 - this PR will introduce breaking changes (requires ng14)

jiayihu commented 2 years ago

Looks like this supersedes #52 right? Btw, I'm gonna quickly catch up with Angular and give it a try this weekend, sorry for the wait.

TheDelta commented 2 years ago

Looks like this supersedes #52 right? Btw, I'm gonna quickly catch up with Angular and give it a try this weekend, sorry for the wait.

Exactly. This includes #52 + Angular upgrade. Depending on how you want to handle it. (offer a new version for angular <=13 or bump and require angular 14) Unsure if it works with older versions, tbh.

No worries for the delay - Thanks for taking a look at it, appreciate it :)

jiayihu commented 2 years ago

Okay so I gave the PR a try and made only a few changes that you can cherry-pick from https://github.com/jiayihu/ng-animate/commit/d1a6b86b5ac507d21444873c3d21b816d91ed58a They are small changes:

The package is already published in npm: https://www.npmjs.com/package/ng-animate

I've also briefly tested installing the lib with Angular CLI 12 and the animations seem to work fine. So once you've cherry picked my changes, I can merge the PR. Thank you very much, you did a great job. Loved also the addition of the Advanced params section in the demo.

jiayihu commented 2 years ago

The demo website has also been published to https://jiayihu.github.io/ng-animate/

TheDelta commented 2 years ago

Awesome 🚀 Thanks for the feedback and looks great, I'll get it done asap. I noticed a bit different formatting for list of animations in the README on NPM, I'll fix that too and will be picked up in the next release properly.

TheDelta commented 2 years ago

Made the cherry pick + eventually fixed the spacing issue on NPM. I could not verify it on NPM, but the markdown preview of VSCode made the same odd spacing issue, which was resovled by adding html comments. (source: https://stackoverflow.com/a/41212443/5152479)

jiayihu commented 2 years ago

Merged 🎉