jiayouxjh / grafx2

Automatically exported from code.google.com/p/grafx2
0 stars 0 forks source link

Brush Container #135

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
A feature originally from Brilliance, also available in ProMotion.
It is a repository for quickly storing/restoring brushes. You have this
window with slots and you place the currently picked brush in a slot with
RMB and load it with LMB. When full, the slot shows a preview of the brush.
In brilliance, picking a brush from a slot would empty the slot, but you
could always do a leftclick-rightclick to have it both picked and stored.

Ideally there would be an option to save/load (/append?) the brush bank.

It makes work without layers much easier.

Original issue reported on code.google.com by ilija.melentijevic on 5 Mar 2009 at 2:57

GoogleCodeExporter commented 9 years ago
May be merged with animbrushes.
We could have animbrushes with a mode where brush change at each drawing on 
screen
(like shade for colors), and another one where you can switch from one frame of 
the
brush to another by some key shortcut.

Anyways, we should also add some kind of layers to the picture.

Note : yo ucan use the spare page to store some temporary brushes. But you have 
to
capture them back each time you want to use them. 

Original comment by pulkoma...@gmail.com on 5 Mar 2009 at 3:13

GoogleCodeExporter commented 9 years ago
In both DPaint and briliance (if I remember correctly) you were able to use 
shortcuts
for left-click (some two keys pressed together, not really a SHORT-cut but a 
keyboard
equivalent of a mouse-click) to paste the brush AND have it advance to the next
frame. It also advanced the animation to the next frame. This, for example, 
made it
very quick to paste an animbrush into an animation.

We could have some switches for this kind of behavior instead.

Original comment by ilija.melentijevic on 5 Mar 2009 at 3:27

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Transcript of a mail by Ilija:
-----

Brush container looks like this:
.-----------------------------------------------------.
|  1      |  2      |   3      |  4      |  5      |  ....
|         |         |          |         |         |
'-----------------------------------------------------'

*Numbers are not visible on screen, they are just for explanation.

Okay so in this example, we have 5 slots. Initially they are empty. When you 
pick up 
a brush, you can right-click on a slot to paste the brush into it. You can then 
see 
a lousy little preview in that slot. In this manner you can place lots of 
brushes in 
slots. They are recalled from slots by left-clicking a slot. In some programs, 
picking a brush from slot empties that slot (but you can just left then right 
click 
a slot to keep the brush in it). This more or less behaves like those neat 
bookmarks 
that we have in the file menu. It is also similar to that window where you can 
pick 
patterns for fill that we have.

There is always the problem of User Interface, or how to integrate it. One way 
would 
be a window (gotta have a neat shortcut for opening/closing) so you can 
pick/store a 
brush and then close the window. For brush container it would work okay, but 
for 
layers it would be terrible. I have an idea that MIGHT work. The idea is to 
HOLD a 
key to show the menu, and when you release the key, the menu is gone.((yr: I 
described this in issue 179)) (...). I think brush container is very simple to 
use 
cause you just click one of the slots and you are pretty much done. (...) This 
method would functionally be somewhere between current windows and floating 
windows. 

Original comment by yrizoud on 15 Jun 2009 at 11:59

GoogleCodeExporter commented 9 years ago
Please use the "Blocked on" field to mark related issues :)

Other than that, i think we need to start by rethinking the page-list system 
and 
make sure we can support
-Layers
-Frames (for animation)
-More than 2 pages
-Use it both for pages and brushes
-Keep an efficient backup system

The combination of all these features will make a pretty complex 
multiple-linked-
list and we have to find an efficient way of storing it and still being able to 
find 
a particular page fast...
Hash maps may be used in there...

Original comment by pulkoma...@gmail.com on 15 Jun 2009 at 2:45

GoogleCodeExporter commented 9 years ago
I think it would be nice if it was able to store mono (resizable) brushes as 
well.

This doesn't seem to need wait a rethinking of Pages, as it's not dependent: 
You copy
a brush to a container or a contained one to "current brush", but you don't 
keep a
link between the two.
The data required for stored brushes would be:
- Paintbrush shape (from PAINTBRUSH_SHAPES: can be pixel in color, pixel shown 
mono,
square, round...)
- Size (for mono brushes)
- Width & Height (for pixel brushes)
- Palette (for pixel brushes)
- Brush original BG color (for pixel brushes, not handled yet)
- 16x16 thumbnail (mono brushes), in GUI colors.
- Pixel brush thumbnail (designed for its own palette, but displayed according 
to
current screen palette)

Original comment by yrizoud on 17 Aug 2009 at 11:44

GoogleCodeExporter commented 9 years ago
Workable version in r1001.
I coded the screen as very easy to add columns or lines, or the size of 
buttons; so
don't hesitate to comment on them, we'll adjust according to what is most 
practical.

There will be a shortcut key to call (and also dismiss) this menu.

I'm not sure if it should be hooked on the menu buttons... I set it as 
right-click
"Brush FX" to test, but it's far from intuitive and right-click "Brush grab" is
already taken.

I can improve the scaled previews, right now they don't respect proportions.

I'm really considering merging this screen with the paintbrush selection (F4): 
Let
the user overwrite any of the 48 paintbrush slots with his custom brushes. And
provide a standard shape selector, as a dropdown list, to allow recreate any 
standard
brush.

Original comment by yrizoud on 20 Aug 2009 at 11:57

GoogleCodeExporter commented 9 years ago

Original comment by pulkoma...@gmail.com on 15 Sep 2009 at 7:14

GoogleCodeExporter commented 9 years ago
This screen was actually moved to paintbrush selection.
Yves, what is the status ? Do you plan on doing more ? (brush previews ?) Or is 
it 
ok to close the issue ?

Original comment by pulkoma...@gmail.com on 1 Nov 2009 at 10:17

GoogleCodeExporter commented 9 years ago
I'd say it's fine, let's wait for user feedback.

Original comment by yrizoud on 2 Nov 2009 at 1:10