jiayouxjh / grafx2

Automatically exported from code.google.com/p/grafx2
0 stars 0 forks source link

Problem with X-Swap #262

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1) Create a new image with just RGB and V in the palette.
2) Draw the letters "R G B" in their respective colors on the black canvas.
3) Open the palette menu and x-swap G and B. Click OK.
4) Scribble something on the canvas.
5) Click undo once to undo the scribble.

What is the expected output? What do you see instead?
The letter G becomes blue and the letter B becomes green, as if the x-swap 
you'd done before 
suddenly turned into a standard swap.

What version of GrafX2 are you using? On what operating system?
r1226 on 32-bit LinuxMint 7 Gloria

Please provide any additional information below.
You can also take many more undo-able steps and it will still mess up your 
colors if you undo even 
once.

Original issue reported on code.google.com by cameron...@comcast.net on 27 Nov 2009 at 4:17

GoogleCodeExporter commented 9 years ago
Yep, I didn't complete this part. This is not even linked to Undo: After an 
X-swap,
swap to spare and back, or change the active layer (2 things that don't modify 
the
image's history), and you'll the remap is already forgotten.

(internal notes: X-Swap doesn't remap the layers, only the visible buffer. Need 
to
test all palette operations when this is done, because the history may not be 
handled
well anyway. Normal behavior should be as follows :  First backup saves 'no 
layers'
because normally only the palette is going to be changed. If there's any remap 
(and
only the first time), it should first do a full backup - and even *replace* the
original, so it will appear as a single atomic Undo/Redo step. Also, on Cancel, 
the
current backup should be rolled back so it's not in the Undo/Redo chain.)

Original comment by yrizoud on 2 Dec 2009 at 1:09

GoogleCodeExporter commented 9 years ago

Original comment by pulkoma...@gmail.com on 15 Jan 2010 at 7:39

GoogleCodeExporter commented 9 years ago
Should be fixed in r1271.

Original comment by pulkoma...@gmail.com on 17 Jan 2010 at 8:37