search

jiayouxjh / grafx2

Automatically exported from code.google.com/p/grafx2
0 stars 0 forks source link

buffer overflow in buttons.c crashes grafx2 ( FIX INCLUDED :) ) #356

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
 I just wanted to add some text to my picture and realised, that clicking "Text" (or pressing its shortcut) crashes grafx2.
What is the expected output? What do you see instead?
 -
What version of GrafX2 are you using? On what operating system?
 - svn revision 1504, Ubuntu 8.10
Please provide any additional information below.
 it crashes in 
buttons.c:4788:
      Num2str(font_size,size_buffer,3);
 FIX:
buttons.c:4721:
  char size_buffer[3];
===>
  char size_buffer[4];

Dont forget to use the labels to mention your Operating system (OpSys-*)
 - hell I dont know where to place that label, sorry :)
and the version of grafx2 you are using (Milestone-2.0 or Milestone-2.1).

Original issue reported on code.google.com by fanickbux@gmail.com on 15 Jun 2010 at 8:15

GoogleCodeExporter commented 9 years ago 
Mh... who said we would'nt need 4-digit font sizes ? :)

Original comment by pulkoma...@gmail.com on 15 Jun 2010 at 9:03

GoogleCodeExporter commented 9 years ago 
Fixed in r1511. Thanks for reporting, I'm using win98 so I don't have crash in 
such case.

Original comment by yrizoud on 15 Jun 2010 at 7:36