cursor is not visible on white on DPaint skin

[GoogleCodeExporter]

What steps will reproduce the problem?

 Having an image with white parts. 

What is the expected output? What do you see instead?

 expected is that it is visible and i don't see the cursor instead.

What version of GrafX2 are you using? On what operating system?

 grafx2-2.2.1430.win32.exe 

 OpSys-Windows_XP_Professional

Original issue reported on code.google.com by HoraK-...@web.de on 2 Aug 2010 at 9:49

[GoogleCodeExporter]

Here I get a perfectly visible crosshair cursor.
Are you sure there is a visible cursor at all in the tool you are trying to use 
? If it's only showing a preview brush, it's expected you can't see it.

Original comment by pulkoma...@gmail.com on 2 Aug 2010 at 9:59

[GoogleCodeExporter]

I'm pretty sure that it's because he's using the DP skin, its normal cursor has 
no black outline.

I had already hesitated to change it myself because it was intentional change 
by Jamon, and nobody complained.

I can see one way to please at least 2 users: Move this borderless cursor to 
the 'thin' cursor, and add black borders on the 'normal' cursor. This way, 
Jamon can still use his preferred cursor by selecting 'Thin'.
This removes the possibility to have the dotted cursor in this skin, but I 
don't think it's a problem, Jamon hadn't changed it (IIRC) from the default 
skin.

Original comment by yrizoud on 2 Aug 2010 at 10:21

• Added labels: OpSys-All
• Removed labels: OpSys-

[GoogleCodeExporter]

Hi,

yes the new Version started with the DP Skin I changed back to the classic skin 
now all is allright, thx for the help.

... greetings HoraK-FDF

Original comment by HoraK-...@web.de on 3 Aug 2010 at 2:43

[GoogleCodeExporter]

Thanks for the confirmation.
Here's more information about the topic, for anybody who might search Issues 
for the topic of "cursor":
Grafx2 allows the user to choose between 3 mouse cursors for the drawing tools. 
Two of them are defined by the skin, and called "Normal" and "Thin". 
Historically, it's because the program had two hard-coded bitmap cursors: 
- Normal cursor : White with a black outline, it makes it very visible on all 
backgrounds.
- Thin cursor: made of alternating white and black pixels, it's slightly less 
visible (especially on dithered BG at x1 zoom) but arguably the cursor occupies 
much less surface of the image.
The last cursor is called "Transparent", it's always two crossing XOR lines : 
It's a cursor whose color changes according to the image colors, exactly like 
the box when you grab a brush.

It's true that any user can modify a skin to suit his preference (ex: I *do* 
use a modified DPaint skin where the cursor has black lines), but I'm aware 
that we still should know and react if the default choices are bad for a 
significant number of people.

In what I proposed in comment 2, there is still something that I don't like: 
Since the white thin cursor was default in Jamon's skin, it was pretty 
consistent with the UI, and people who selected this skin were automatically 
living the "full experience". If I "fix this cursor", it's no longer visible 
that Jamon intended his skin to be "best used with thin white cursor".

At the core, I think the problem is that it's not clear when you change a skin 
that you change the set of cursors, and the relation between mouse cursors and 
the dropdown "Cursor" is not so evident... If you want to know what it does, 
you need to change the setting.
I can see one way to improve this: in the skin screen, instead of a dropdown 
list to choose Normal/Thin/Transp, we should display the three cursors with an 
outline around to chosen one. It would behave like the preview area, ie. 
whenever the user browses to another skin that has different cursors, this 
display would update the first two cursors, so the user immediately knows what 
his selected cursor will look like - and can immediately switch to the second 
cursor if he finds it better-looking.
This has the added benefit that the second cursor doesn't need be related to 
the name "Thin".

Original comment by yrizoud on 3 Aug 2010 at 5:26

[GoogleCodeExporter]

Original comment by pulkoma...@gmail.com on 6 Aug 2010 at 3:43

• Changed title: cursor is not visible on white on DPaint skin
• Added labels: Component-NotCode

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Original comment by pulkoma...@gmail.com on 22 Aug 2010 at 1:39

• Added labels: Milestone-2.3
• Removed labels: Mil

[GoogleCodeExporter]

I think it doesn't make much sense to use this cursor.
Yes, the skin is a tribute to deluxe paint, but that shouldn't alter usability.

We allow to select between 3 cursors which are pretty useable, sane defaults. 
If someone wants to go the old-oldskool way (GrafX2 is already the oldskool way 
:)); they can make the skin themselves.

I vote for just fixing the skin.

Original comment by pulkoma...@gmail.com on 18 Feb 2011 at 12:40

[GoogleCodeExporter]

Done in r1741.

Original comment by yrizoud on 28 Feb 2011 at 8:05

• Changed state: Fixed