jiayouxjh / grafx2

Automatically exported from code.google.com/p/grafx2
0 stars 0 forks source link

Monochrome bitmap fonts should render as monochrome brush, not color one. #382

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
(by DawnBringer)
The PF fonts (and others perhaps) are very weird with the colors. You can't get 
the right color, it selects the closest to black whatever you do. Use black as 
bg and you get nothing, use dark grey bg and you get a text+some background 
color, select a medium to bright bg and you get a black transparent text?!

Original issue reported on code.google.com by yrizoud on 2 Sep 2010 at 11:35

GoogleCodeExporter commented 9 years ago
Grafx2 automatically substitutes the original "background" pixels of the bitmap 
font to your BG color, because it will make them appear transparent in the 
brush. This leads to several issues:

#1) In the PF_ fonts, the only non-transparent pixels are black. If you have 
black as your BG color when you render text with them, Grafx2 "sees" all black 
pixels, so all transparent.

#2) The method that I've used to map the font colors with the current image's 
colors seems inaccurate. There are many cases where instead of a transparent 
background, your brush gets a solid background whose color is close to your BG 
color.

By the way, the method that I use with these fonts is to set BG color anything 
non-black; I render the text; then I right-click the Brush selection icon to 
"monochromize" the brush: From this point, I can change FG to any color that I 
want to paint text. Except the BG color that I had selected initially. And I 
can't change BG, as it would instantly turn the brush in a solid rectangle, 
unusable (Issue 81 would solve it, but it seems I haven't been convincing)

Original comment by yrizoud on 2 Sep 2010 at 11:58

GoogleCodeExporter commented 9 years ago

Original comment by pulkoma...@gmail.com on 20 Jan 2011 at 8:47

GoogleCodeExporter commented 9 years ago
Recent changes fix the second issue : the font's transparent index is now 
always mapped to current BG, except in some special fonts where the BG can't be 
detected (Grafx2 has none of those, but I have found some).

Still todo: 
- Fix preview visiblity (checkered background ?)
- Fix color mapping so that no non-transparent color becomes transparent.

Original comment by yrizoud on 8 Feb 2011 at 10:49

GoogleCodeExporter commented 9 years ago
Fixed somewhere before r1741. Now, unless the font image itself is badly done, 
the screen is guaranteed to show a usable background and the font's colors.

Original comment by yrizoud on 28 Feb 2011 at 8:07