search

jiayouxjh / grafx2

Automatically exported from code.google.com/p/grafx2
0 stars 0 forks source link

C64 multicolor saver broken in 2.4. #522

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Saving of C64 multicolor images does not work in 2.4, the exact same images 
saves just fine in 2.3.

Load any 160x200 multicolor bitmap saved with 2.3, it will not save again in 
2.4. It just flashes the screen red, as if it detected an error during the 
format checking.

I tested this with my own build in Ubuntu and with the official binary on 
Windows XP. I get the same result on both platforms.

Original issue reported on code.google.com by mikeri...@gmail.com on 25 Dec 2012 at 10:53

GoogleCodeExporter commented 9 years ago 
I just had a look at this myself, in 2.4, line 2891 in miscfileformats.c is:
File_error = Save_C64_fli(filename,saveWhat,loadAddr);
I changed this to
File_error = Save_C64_multi(context,filename,saveWhat,loadAddr);
like it was in 2.3, now multicolor saving works in 2.4 here.

Original comment by mikeri...@gmail.com on 26 Dec 2012 at 5:13

GoogleCodeExporter commented 9 years ago 
Fixed in r2043. Files will be saved as FLI only if the file extension is ".fli" 
(case insensitive), else they will be saved in plain multicolor format.

Original comment by pulkoma...@gmail.com on 29 Dec 2012 at 7:02