search

jibsen / brieflz

Small fast Lempel-Ziv compression library
zlib License
100 stars 18 forks source link

ecm brieflz changes #5

Closed ecm-pushbx closed 6 years ago

ecm-pushbx commented 6 years ago
jibsen commented 6 years ago

Thank you for the pull request. I looked into the Travis failure, and it is not related to your changes, but rather it appears Travis sometimes fails to run address sanitizer on their container-based images.

Regarding the changes; in general I think it is a good idea to use blz_depack_safe(), but for the example program I'd prefer to keep it as fast as possible, because it is used for timing BriefLZ in some compression library comparisons. This is also the reason checksums are disabled by default.

ecm-pushbx commented 6 years ago

Thanks for the review! Will you merge the other commit? It's not huge obviously, but yeah.

By the way, I used BriefLZ for my kernel, described in https://www.bttr-software.de/forum/forum_entry.php?id=15474