only use sudo when required

jide / clamp

Command Line Apache MySQL PHP

http://jide.github.io/clamp

GNU General Public License v2.0

79 stars 9 forks source link

Closed aerickson closed 5 years ago

aerickson commented 5 years ago

Host: Now checks if user has specified a non-localhost hostname before setting with sudo.
Apache: Detect if user has specified a privileged port and they're on <10.14, if they are use sudo.
- Also explains to user why sudo is being added.
MySQL: Don't use sudo. Port 3306 is non-privileged.
Comand: Add sudoRequired helper function.

aerickson commented 5 years ago

Happy to add a check for sudo for MySQL also.

rqelibari commented 5 years ago

@aerickson You are on fire! Looks amazing! I will look it through and merge it.

rqelibari commented 5 years ago

@aerickson Did you see my question about reset in the code?

aerickson commented 5 years ago

Thanks :).

Sorry for the delay. Replied to above. Happy to work on an alternative way of getting the value.