search

jidesoft / jide-oss

JIDE Common Layer
Other
185 stars 81 forks source link

JideTabbedPane: two tabs with the same title leak the closeable flag to each other #6

Closed hakanai closed 10 years ago

hakanai commented 10 years ago

Whether a tab is closeable or not is determined by its title:

    if (_closableMap.containsKey(getTitleAt(index))) {
        contains = true;
    }

This means that if you have two tabs with the same title, setting one tab to closeable will inadvertently set it for both.

jidesoft commented 10 years ago

Thanks for the bug report. I'll fix it so that it uses the Component as the key in the closableMap instead of using the titles that may or may not be unique.

jidesoft commented 10 years ago

Fixed. https://github.com/jidesoft/jide-oss/commit/1813e6f7c0d5698761e27455767c62a4bf1000ca