search

jief666 / hdimount

Mount apple disk image (HFS, APFS, partitioned or not, compressed, encrypted) via Fuse
GNU General Public License v3.0
33 stars 2 forks source link

Fix build on Fedora, openSuse etc. - use sys/xattr.h instead of attr/xattr.h #9

Closed kapitainsky closed 2 years ago

kapitainsky commented 2 years ago

Following on #8

Applications should use sys/xattr.h instead of attr/xattr.h which is missing in many distros (Redhat, Fedora, openSuse, Centos) and existing source code will not compile.

Proposed change should work on all distros - tested on Debian, Fedora and openSuse

jief666 commented 2 years ago

ENOATTR is always supposed to be equal to ENOATTR ?

kapitainsky commented 2 years ago

ENOATTR is always supposed to be equal to ENOATTR ?

I have tried get the broader compatibility as sys/errno.h

return ENODATA, while ENOATTR is not defined: Linux return ENOATTR, while ENODATA is not defined: FreeBSD

jief666 commented 2 years ago

If I understand well, if I want to compile on FreeBSD, I'll have #ifdef and adapt this include of xattr.h and the #define. Am I correct ?

kapitainsky commented 2 years ago

Yes but I do not have FreeBSD to test now

On 28 Jun 2022, at 16:03, jief666 @.***> wrote:

If I understand well, if I want to compile on FreeBSD, I'll have #ifdef and adapt this include of xattr.h and the #define. Am I correct ?

— Reply to this email directly, view it on GitHub https://github.com/jief666/hdimount/pull/9#issuecomment-1168840010, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXJHOTVDDC5JUQCZHZIDRLVRMH3ZANCNFSM52CNDFEQ. You are receiving this because you authored the thread.