Write padding in unlink response

jiegec / usbip

A Rust library to run a USB/IP server

MIT License

255 stars 25 forks source link

Write padding in unlink response #10

Closed jamesadevine closed 1 year ago

jamesadevine commented 1 year ago

As per documentation, an USBIP_CMD_UNLINK response should return 24 bytes of padding.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4114585569

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 41.641%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/lib.rs	0	1	0.0%
<!--	Total:	0	1	0.0%	-->

Totals
Change from base Build 4061119800:	-0.08%
Covered Lines:	533
Relevant Lines:	1280

💛 - Coveralls

jiegec commented 1 year ago

Wow, the Linux documentation finally provides the structure definition. When I was writing the library, the documentation was so poor that I had to read through linux kernel code.

jamesadevine commented 1 year ago

@jiegec It might be good to review the other calls too based on the documentation. I'm pretty sure there is another case that needs to be handled with USBIP_CMD_UNLINK. See status description below: