Incorrect Constant Values for Standard Device Request Codes

jiegec / usbip

A Rust library to run a USB/IP server

MIT License

278 stars 26 forks source link

Incorrect Constant Values for Standard Device Request Codes #20

Closed 313ctric closed 1 year ago

313ctric commented 1 year ago

In consts.rs the codes for SetInterface and SynthFrame (should be SynchFrame) are incorrect. They are currently 0x11 and 0x12 respectively, but should be decimal 11 and 12 (0x0B and 0x0C).

They are specified in Table 9-4 of the USB 2.0 specification. https://www.usb.org/document-library/usb-20-specification (usb_20.pdf, page 251).

I would be happy to create a pull request, but it's such a small fix it would probably be quicker for someone else to just do it.

Thanks

jamesadevine commented 1 year ago

Please make a PR - github.dev exists!

Thanks

jiegec commented 1 year ago

I was referring to https://www.beyondlogic.org/usbnutshell/usb6.shtml#StandardDeviceRequests, so it seems that the website is wrong as well.

jamesadevine commented 1 year ago

I have informed the author of usb in a nutshell!