search

jieter / Leaflet.Sync

Synchronized view of two maps.
http://jieter.github.io/Leaflet.Sync/examples/dual.html
BSD 3-Clause "New" or "Revised" License
235 stars 53 forks source link

fix: avoid flicker on zoomend #42

Closed jjimenezshaw closed 7 years ago

jjimenezshaw commented 7 years ago

Due to the reset: true option in setView, on every zoomend there is a flicker on the maps. This reset option is needed, specially for multi touch devices, because the zoom is computed in a different way. So after every zoom we must reset the internal positions. This flicker is specially annoying because it happens when the zoom is already (successfully and nicely) done. The reason is an invalidateAll, that removes every tile, and loads them again when reset is enabled.

The only way to fix it I have found is to disable temporarily the event 'viewprereset', and restore it later, just in case. I didn't find any other way to disable an event and restore it later. This is done only for the internal calls, like in zoomend.

You can see a simple comparison here (it does not use Sync plugin, just tries to show the efect): https://jsfiddle.net/La220nrg/1/ The map below flicks. The upper one removes the event, and does not flick.

jieter commented 7 years ago

Looks much better, thanks!

jieter commented 7 years ago

Released leaflet.sync@0.1.1