search

jieter / django-tables2

django-tables2 - An app for creating HTML tables
https://django-tables2.readthedocs.io/en/latest/
Other
1.88k stars 426 forks source link

Meta model type checking #775

Closed flaiming closed 2 years ago

flaiming commented 3 years ago

I have problem running django-tables2 (version 2+) with django-crudbuilder. Issue boiled down to Meta model type checking and I found a quick fix - just don't do it. This is fixing the issue and everything is working as expected.

Digging deeer: Crudbuilder is dynamically creating Table classes, which involves adding meta class dynamically. Currently it's making Meta class derived from plain object, therefore raising TypeError at django-tables2 _check_types() method. I tried to derive Meta class from django Model, but that caused another error.

So is this model check really necessary? Could you please direct me to what I should do to fix this issue?

This isssue is related to #643

russell310 commented 2 years ago

Issue fixed https://github.com/asifpy/django-crudbuilder/pull/76. No issue on django-tables2

flaiming commented 2 years ago

@russell310 Thanks! :)