search

jieter / django-tables2

django-tables2 - An app for creating HTML tables
https://django-tables2.readthedocs.io/en/latest/
Other
1.89k stars 428 forks source link

fix(i18n): Update django.po for Ukrainian 🇺🇦 #934

Open DmytroLitvinov opened 11 months ago

jieter commented 11 months ago

@DmytroLitvinov thanks for the PR!

Does this only change the case of the first letter of each message? Translations should use the same capitalisation as the original message, unless the language writing rules dictate a capital (i.e. "All German nouns are capitalized.").

Whether or not these capitals are used for other languages is a preference, and should not be dictated by the translation files. If you need uppercase first letters, you should use a custom template with added |capfirst filters.

DmytroLitvinov commented 11 months ago

Hi @jieter,

in that case, I see that Ukrainian letters are not used for translation.

In our case we are not required as in German provides nouns in capitalized way. It is not required and not strict. And yes, if some even need it - they can use |capfirst as you wrote. I just followed translation file and did in the same register.