search

jieunbyun / BNS-JT

Reference: Byun, J.-E. and Song, J. (2021). A general framework of Bayesian network for system reliability analysis using junction tree. Reliability Engineering & System Safety, 216, 107952.
MIT License
5 stars 4 forks source link

Using instance of Variable class in defining variables of Cpm #16

Closed dynaryu closed 1 year ago

dynaryu commented 1 year ago

I guess Variable needs to be defined prior to Cpm. In this case, there is no need to use v_info as they're already in the scope. Let me know your thoughts.

Caused a problem with sorting of new_child during product operation

jieunbyun commented 1 year ago

I agree. Thank you for the good idea : D

dynaryu commented 1 year ago

I created a branch and making some changes there. When I'm done, I'll merge it to the python branch. Also another important change that I'm considering is using 0-based index when writing C matrix. Let me know your thoughts.

jieunbyun commented 1 year ago

I agree on using 0-based indexing. In the context of Python, it makes more sense.