search

jieunbyun / BNS-JT

Reference: Byun, J.-E. and Song, J. (2021). A general framework of Bayesian network for system reliability analysis using junction tree. Reliability Engineering & System Safety, 216, 107952.
MIT License
5 stars 3 forks source link

Merge the changes #31

Closed dynaryu closed 9 months ago

dynaryu commented 9 months ago

Two things to discuss:

  1. Would it be nice to add comps_name in the Branch class?
  2. Originally down_state and up_state of the Branch class need to be integer, but now they are strings in the gen_bnb. Any thoughts?
dynaryu commented 9 months ago

I broke the main part of the do_gen_bnb routine into several small routines. The names are a bit arbitrarily set ATM, so please feel free to change them appropriately. Also, I've added some tests in the tests/test_gen_bnb.py tests/test_pipe.py. You might want to add more tests.

jieunbyun commented 9 months ago

Very good points! hmm...

  1. Yes it is a nice idea. I've found "comps_name" was necessary here and there. In that way, we would not have to restrict "varis" to include only component events.
  2. That is quite correct.. Let's stick to integer! For the moment, I'd like to consider only binary state (for B&B becomes quite inefficient when it comes to multi-state, and if multi-state is wanted we can apply it consecutively <- which I am considering as one of our next steps). But just in case we'd better leave some room for generalisation.