jiffy-labs / jiffyscan-frontend

https://jiffyscan-frontend.vercel.app
MIT License
20 stars 26 forks source link

Vanar-testnet section shows unexpected behaviour #147

Open shashankcoc opened 2 months ago

shashankcoc commented 2 months ago

While opening vanar-testnet it takes up a whole section of the screen, it should have scroll functionality.

Adding scroll functionality will make the web app more readable.

image

image

Similarly for this Search section also.

image

can I work on this issue ? @lazycoder1

lazycoder1 commented 2 months ago

Go for it ser !

shashankcoc commented 2 months ago

image

Hi, I have added the scroll functionality to both of the options and search component. Just wanted to know for which branch I should raise Pull request bcoz I can't find any UI related branch.

lazycoder1 commented 2 months ago

Could you do it to the development please ?

shashankcoc commented 2 months ago

ok sure!

created the PR #148 I have one question authorization check failed for vercel is it necessary to authorize and deploy ?

This fix include all other page fixes ->

Earlier: image

Now image

NECROMANCER01 commented 2 months ago

Hey Shashank, Thanks for contributing, I took your solution and tried redesigning it in our design system. Dropdown

Because there are too many networks to scroll through, I devised a solution.

Can you make those changes? Let me know if you need the Figma file or other resources for reference.

shashankcoc commented 2 months ago

Hi, yes a design figma would be helpful.

NECROMANCER01 commented 2 months ago

Hey here is the prototype demo

https://github.com/jiffy-labs/jiffyscan-frontend/assets/40258234/62661734-8350-45f1-819c-3d7fed5f34fd

And here is the Figma file for the Dropdown feature, Prototype included

https://www.figma.com/design/YJCCv4Sb1laqAZ0g5D1GXf/JiffyScan---DropDown-Feature?node-id=0-1&t=ntUUYdRUckKjyf3u-1

Let me know if there's anything I can help

shashankcoc commented 2 months ago

Hii, Raised PR please check , #150