search

jiffyclub / palettable

Color palettes for Python
https://jiffyclub.github.io/palettable/
Other
768 stars 73 forks source link

Fix missing asterisk (#52) #53

Closed penguinpee closed 1 year ago

penguinpee commented 1 year ago

The asterisk is needed or submodules won't be included in some cases.

penguinpee commented 1 year ago

This is a follow up / fix for #52. I found out the hard way that the asterisk is needed.

I believe, but haven't tried yet, that dropping the entire [tool.setuptools.packages.find] table would make autodiscovery of setuptools work. The exclude never made sense to me. But having it means the default exclude filter is deactivated. Thus an explicit include (with asterisk) is needed.

Switching to a src layout may also be something worth considering. It will save you a lot of headaches in the future wrt to setuptools and module discovery. For some background, see the discussion I had with the PyPA folks.

jiffyclub commented 1 year ago

I'll take your word for it!

penguinpee commented 1 year ago

I'll take your word for it!

Thanks. There's evidence, too: https://copr.fedorainfracloud.org/coprs/gui1ty/neuro-sig/build/6017925/

There you see the build for F37 failing. The builds for F38 and rawhide succeeded. But they are littered with deprecation warnings for every submodule. That's most likely due to a different version of setuptools being used in these builds. But I wasn't able to put my finger on a specific change.

You can inspect the build logs if you like. :wink: