jigar-joshi / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

srtp-cvs will not build in 0.5.4 / linux #165

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run $path_to_swtoolkit/hammer.sh

What is the expected output? What do you see instead?
I expect libjingle-0.5.4 and its third party dependencies build. Instead, srtp 
fails with the following: 

third_party/srtp/srtp/ekt.c: In function 'srtp_stream_init_from_ekt':
third_party/srtp/srtp/ekt.c:169:12: error: variable 'master_key_len' set but 
not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors

scons: *** [build/dbg/obj/third_party/srtp/srtp/ekt.o] Error 1
scons: building terminated because of errors.

What version of the product are you using? On what operating system?
I am using libjingle-0.5.4, srtp-cvs from this site, and I'm running Arch Linux 
(x86_64). 

Please provide any additional information below.
My system is up to date and all the tools and env variables appear to be set 
right. SRTP simply has a bug; will try with other versions but the zip file 
available under Downloads does not build. 

Original issue reported on code.google.com by roken...@gmail.com on 15 May 2011 at 11:18

GoogleCodeExporter commented 9 years ago
I am a moron and please forgive me. My much simpler question is, how might I 
change the compiler flags using SCons? (I have never used this build system) I 
would like to not treat all warnings as errors. 

Original comment by roken...@gmail.com on 15 May 2011 at 11:45

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
The build should work if you follow the instructions exactly. This has been 
verified, but if you want to build it differently, then it has higher risk that 
it won't work properly.
One thing I noticed is that you need to rename the "srtp-cvs" folder to "srtp". 
Please reopen this issue if you still run into any problem after following the 
instructions.

Original comment by jun...@google.com on 23 May 2011 at 9:44

GoogleCodeExporter commented 9 years ago
Hi
I found the same issue 
my srtp-cvs is renamed to srtp and I have received the same error. 
Any clues as to how you resolved this roken?

Original comment by mrco...@gmail.com on 28 Nov 2011 at 12:27

GoogleCodeExporter commented 9 years ago
Hi,
I found the same issue too,
Can anyone tell me the result?
Thanks

Original comment by LJack...@gmail.com on 20 Dec 2011 at 3:57

GoogleCodeExporter commented 9 years ago
I searched a couple weeks ago and didn't find this ticket, so I opened Issue 
#252.  The response there was that the problem is in libsrtp, so it won't be 
fixed.  I submitted a patch to libsrtp, which has yet to get a response.

http://sourceforge.net/mailarchive/message.php?msg_id=28516378

The fix for libsrtp is simple, but getting it propagated through is not.  I 
would suggest finding the spots in talk/main.scons that makes it treat warnings 
as errors (varies by platform) and disable that.  Really, I think 
warnings-as-errors should be disabled in libjingle SVN if there are dependent 
projects (libsrtp) with warnings that won't be fixed.

Original comment by bprodo...@connectify.me on 20 Dec 2011 at 4:01