jigar-joshi / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

Building Linphone with libjingle-0.5.6 broken #179

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install libjingle and all the dependencies, including linphone
2. Modify libjingle.scons as described in libjingle-0.5.6's readme
3. Run hammer.sh

What is the expected output? What do you see instead?
The build should succeed with the Linphone capabilities built in.  Instead, I'm 
getting this error:
In file included from session/phone/mediaengine.cc:31:
/home/dlewanda/jingle/libjingle-0.5.6/talk/session/phone/linphonemediaengine.h:1
31: error: conflicting return type specified for 'virtual void 
cricket::LinphoneVoiceChannel::SetRingbackTone(const char*, int)'
/home/dlewanda/jingle/libjingle-0.5.6/talk/session/phone/mediachannel.h:259: 
error:   overriding 'virtual bool 
cricket::VoiceMediaChannel::SetRingbackTone(const char*, int)'
session/phone/mediaengine.cc: In static member function 'static 
cricket::MediaEngine* cricket::MediaEngine::Create()':
session/phone/mediaengine.cc:42: error: cannot allocate an object of abstract 
type 'cricket::LinphoneMediaEngine'
/home/dlewanda/jingle/libjingle-0.5.6/talk/session/phone/linphonemediaengine.h:5
1: note:   because the following virtual functions are pure within 
'cricket::LinphoneMediaEngine':
/home/dlewanda/jingle/libjingle-0.5.6/talk/session/phone/mediaengine.h:127: 
note:   virtual bool cricket::MediaEngine::GetOutputVolume(int*)
scons: *** [build/dbg/obj/session/phone/mediaengine.o] Error 1
scons: building terminated because of errors.

What version of the product are you using? On what operating system?
libjingle-0.5.6 on Ubuntu 10.10 64-bit

Please provide any additional information below.
I have attached my modified libjingle.scons

Original issue reported on code.google.com by dbl...@alumni.lehigh.edu on 21 Jun 2011 at 9:03

Attachments:

GoogleCodeExporter commented 9 years ago
Hi,

I had the sames errors, i think it is because there was mistakes during the 
implementation of "linphonemediaengine".

For the first error you have to change the return type of the 
"cricket::LinphoneVoiceChannel::SetRingbackTone(const char*, int)" function 
from "void" to "bool".
For the second error you have to implement in "LinphoneMediaEngine" the 
"GetOutputVolume(int*)" which is pure virtual in "MediaEngine"

Maybe it is not the good solution but, now, i can call !

Original comment by guill.ha...@gmail.com on 19 Jul 2011 at 12:35

GoogleCodeExporter commented 9 years ago
Thanks Guill. I also met same problem and the first error did disappear after 
changing the return type. However I don't have a clue of solving the abstract 
class problem. I'm working on libjingle-0.6.0 and there is no GetOutputVolume 
function. But it seems all the functions in linphonemediaengine class are 
abstract, and I need to implement all of them. Is that the situation? Thanks in 
advance.

Original comment by tangketa...@gmail.com on 21 Nov 2011 at 11:55

GoogleCodeExporter commented 9 years ago
What did you define in GetOutputVolume(int*)

Original comment by mitivarun@gmail.com on 17 May 2012 at 9:52

GoogleCodeExporter commented 9 years ago
What did you define in GetOutputVolume(int*)

Original comment by mitivarun@gmail.com on 17 May 2012 at 9:52

GoogleCodeExporter commented 9 years ago
Some of the inherited virtual function are not implemented in 
LinphoneVoiceChannel.

Adding below code in class LinphoneVoiceChannel will resolve these errors.

  virtual bool AddSendStream(const StreamParams& sp) { return true; }
  virtual bool RemoveSendStream(uint32) { return true; }
  virtual bool AddRecvStream(const cricket::StreamParams&) { return true; }
  virtual bool RemoveRecvStream(uint32) { return true; }
  virtual int GetOptions() const { return 0; } 
  virtual int GetTimeSinceLastTyping() { return 0;}
  virtual int SetTypingDetectionParameters(int, int, int, int) { return 0; }
  virtual bool PlayRingbackTone(uint32, bool, bool) { return true; }

Original comment by satyaji...@gmail.com on 24 Jun 2012 at 2:23

Attachments:

GoogleCodeExporter commented 9 years ago
Linphone is no longer supported.

Original comment by juberti@google.com on 31 May 2013 at 8:37