jigar-joshi / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

Expat build error due to missing includedir in libjingle.scons #184

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Just start building libjingle according to the instructions from README.

What is the expected output? What do you see instead?

What I see:
~/work/libjingle-read-only/talk $ hammer.sh 
scons: Reading SConscript files ...

scons: warning: The build_dir keyword has been deprecated; use the variant_dir 
keyword instead.
File "/Users/serge/work/libjingle-0.5.8/swtoolkit/site_scons/site_init.py", 
line 203, in BuildEnvironmentSConscripts
scons: done reading SConscript files.
scons: Building targets ...
________Compiling build/dbg/obj/third_party/expat-2.0.1/lib/xmlparse.o
third_party/expat-2.0.1/lib/xmlparse.c:20:26: error: expat_config.h: No such 
file or directory
third_party/expat-2.0.1/lib/xmlparse.c:81:2: error: #error memmove does not 
exist on this platform, nor is a substitute available
scons: *** [build/dbg/obj/third_party/expat-2.0.1/lib/xmlparse.o] Error 1
scons: building terminated because of errors.

What should be:
~/work/libjingle-read-only/talk $ hammer.sh 
scons: Reading SConscript files ...

scons: warning: The build_dir keyword has been deprecated; use the variant_dir 
keyword instead.
File "/Users/serge/work/libjingle-0.5.8/swtoolkit/site_scons/site_init.py", 
line 203, in BuildEnvironmentSConscripts
scons: done reading SConscript files.
scons: Building targets ...
________Compiling build/dbg/obj/third_party/expat-2.0.1/lib/xmlparse.o
________Compiling build/dbg/obj/third_party/expat-2.0.1/lib/xmlrole.o
________Compiling build/dbg/obj/third_party/expat-2.0.1/lib/xmltok.o
________Creating library build/dbg/obj/libexpat.a
________Indexing build/dbg/obj/libexpat.a
Install file: "build/dbg/obj/libexpat.a" as "build/dbg/lib/libexpat.a"

What version of the product are you using? On what operating system?
OSX 10.6.8, Xcode 3.2.6

Please provide any additional information below.
This issue happens because expat sources include <expat_config.h>, which is 
located in third_party/expat-2.0.1, but only third_party/expat-2.0.1/lib is in 
libjingle.scons' includedirs. The fix is straight-forward:

Index: talk/libjingle.scons
===================================================================
--- talk/libjingle.scons    (revision 72)
+++ talk/libjingle.scons    (working copy)
@@ -12,6 +12,7 @@
              ],
              includedirs = [
                "third_party/expat-2.0.1/lib",
+               "third_party/expat-2.0.1"
              ],
              win_cppdefines = [
                "COMPILED_FROM_DSP",

Original issue reported on code.google.com by gsse...@gmail.com on 4 Jul 2011 at 10:26

GoogleCodeExporter commented 9 years ago
Did you follow the instruction in README file to config the build environment?
* Second, run talk/third_party/expat-2.0.1/configure and
    talk/third_party/srtp/configure.

Original comment by jun...@google.com on 7 Jul 2011 at 11:59

GoogleCodeExporter commented 9 years ago
Yes, I did.

Original comment by gsse...@gmail.com on 8 Jul 2011 at 7:19

GoogleCodeExporter commented 9 years ago
I had this error too. I was compiling from the svn source code. The error was 
corrected following the tip posted here. It seems that libjingle.scons indeed 
has an error because it does not include the folder where expat_config.h is. 
Thanks gsse...@gmail.com

Original comment by diego.cd...@gmail.com on 17 Jul 2011 at 5:12

GoogleCodeExporter commented 9 years ago
I had this error as well.  The fix posted above worked for me.

Original comment by darre...@gmail.com on 26 Jul 2011 at 5:27

GoogleCodeExporter commented 9 years ago
This fix worked for me as well.  

Original comment by ian.sw...@gmail.com on 11 Aug 2011 at 7:25

GoogleCodeExporter commented 9 years ago
Thanks  gsse...@gmail.com 

Original comment by triaphoo on 5 Oct 2011 at 12:48

GoogleCodeExporter commented 9 years ago

Original comment by jun...@google.com on 23 Nov 2011 at 10:45

GoogleCodeExporter commented 9 years ago
The fix des not seem to be applied in trunk and the problem persists.

Original comment by fabian.p...@gmail.com on 24 Jan 2012 at 11:55

GoogleCodeExporter commented 9 years ago
It's March 2012 and the proposed patch was not yet propagated to trunk. And it 
does help.

Original comment by ivuc...@gmail.com on 24 Mar 2012 at 8:32

GoogleCodeExporter commented 9 years ago
I'm getting the same error, but the fix appears to be for Unix as Windows 
doesn't have a "configure" command.  Please advise what us Windows builders 
should do? (no "switch to Unix" comments please)

Original comment by eselk2...@gmail.com on 23 May 2012 at 11:54

GoogleCodeExporter commented 9 years ago
Update: Copying expat-2.0.1\Source\Lib\ to expat-2.0.1\Lib\ seems to have 
gotten me past this issue.  Now it complains about missing windows.h, but I 
think that is related to Windows SDK (I had installed it, but not all files, so 
waiting on the 4GB download/install now).

Original comment by eselk2...@gmail.com on 24 May 2012 at 12:03

GoogleCodeExporter commented 9 years ago
Please reopen: issue persists.

Original comment by bj...@xowave.com on 7 Sep 2012 at 10:41

GoogleCodeExporter commented 9 years ago
I am also seeing this issue. Just downloaded the source today. July 23, 2013

Original comment by jonberl...@gmail.com on 23 Jul 2013 at 11:18