Disallow logging time on closed projects; fixes #62 - Githubissues

jigarius / toggl2redmine

Import time from Toggl 2 Redmine.

GNU General Public License v3.0

26 stars 6 forks source link

Disallow logging time on closed projects; fixes #62 #67

Closed jigarius closed 3 years ago

jigarius commented 3 years ago

The problem

Users should not be allowed to log time on closed projects.
- Even admins should be disallowed because that's the behavior we get in the Redmine UI.

What's done

Updated fixtures for testing this bug fix.
Enabled membership and :log_time permission test for admin users.
Fixed one test that was broken due to the change in fixtures.
The T2R UI prevents users from importing time entries if the associated project is closed.

kporras07 commented 3 years ago

@jigarius this works great! Thanks :)