jigarius / toggl2redmine

Import time from Toggl 2 Redmine.
GNU General Public License v3.0
26 stars 6 forks source link

T2R does not handle ENV[RAILS_RELATIVE_URL_ROOT] #76

Open tonischilling opened 2 years ago

tonischilling commented 2 years ago

Bug summary A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Device information

Additional context Add any other context about the problem here.

tonischilling commented 2 years ago

Hrrg! it happened again ... so Description comes here

Bug summary When using Redmine through a Reverse-Proxy with an URL-prefix, this prefix will not be reproduced in T2R's "backward links".

To Reproduce

  1. Host your Redmine through a reverse proxy with an URL-prefix e.g. "https://from.outside.de/redmine/..." => goes internally to "http://12.34.56.78:8080/redmine/..."
  2. Use it from outside
  3. (most of?) T2R´s backward links will not contain the URL-Prefix - and thus they are broken.

Expected behavior

Context

tonischilling commented 2 years ago

Could fix it -- for me: ( see relevant parts of "git diff v4.3.1 all-my-hacks | tee relative_url.vimdiff" Do not trust the line numbers, because I hacked a couple of other things, which are not part of the diff relativ_url.vimdiff.txt ) Probably there´s is a better - more RAILS-ish way - to do that, but for now and for me it works.

jigarius commented 1 year ago

I've been very busy lately. I'll try to get this one done next. Thanks for the detailed report.