jiggzson / nerdamer

a symbolic math expression evaluator for javascript
http://www.nerdamer.com
MIT License
517 stars 82 forks source link

nerdamer.factor('4677271') returns 4677271, not 2089*2239 #438

Closed Yaffle closed 5 years ago

Yaffle commented 5 years ago

P.S. Probably, unrelated to this issue, but https://github.com/peterolson/BigInteger.js was updated again.

Happypig375 commented 5 years ago

Did you mean pfactor?

jiggzson commented 5 years ago

@Yaffle. Thanks. I'll take care of this.

jiggzson commented 5 years ago

@Yaffle, thanks again for catching this and fixing this. If you're happy with the fix feel free to close this.

Yaffle commented 5 years ago

@jiggzson , Well.... I have stolen the ifactor code from your lib, so - thank you

jiggzson commented 5 years ago

@Yaffle, anytime.