search

jiggzson / nerdamer

a symbolic math expression evaluator for javascript
http://www.nerdamer.com
MIT License
517 stars 82 forks source link

feat: enable different ways to show matrix in LaTeX #496

Closed joao-guilherme closed 3 years ago

joao-guilherme commented 5 years ago

LaTeX has many ways to display an matrix, let's use.

image

jiggzson commented 5 years ago

@joao-guilherme, Thanks. That's a great idea. I've added a comment to the PR so as soon as you make the requested changes I can close this.

jiggzson commented 5 years ago

@joao-guilherme, I was thinking that maybe we can reuse the options parameter. Just so we don't break existing code, we can check if it's a string or an object. If it's a string, proceed as usual. If it's an object we can look for the matrix_type key. What do you think?

joao-guilherme commented 5 years ago

@jiggzson, I'm new here, but looking at the code, I prefer your first idea, because making the option an object adds more complexity than moving the type to the second parameter.

I didn't see where we can break the code, since passing a single parameter, option will have the correct value and type will be undefined

jiggzson commented 3 years ago

Closing. No response given and PR breaks test cases. Added for consideration in #358.