search

jiggzson / nerdamer

a symbolic math expression evaluator for javascript
http://www.nerdamer.com
MIT License
517 stars 82 forks source link

Update the type definitions #551

Closed nishantwrp closed 3 years ago

nishantwrp commented 4 years ago

The nerdamer type defs are not up to date. There are missing functions on nerdamer.Expression like eq etc.

jiggzson commented 4 years ago

@nishantwrp, the functions like the one you mentioned are undocumented so that may be the reason why they were never added. Since they're undocumented, they technically not supported. If you don't mind sending a PR with the updated type defs we can probably start supporting them.

It would be great if you provide that list ahead of time so we can all be on the same page.

nishantwrp commented 4 years ago

I think they are documented here -> https://nerdamer.com/functions/Expression.eq.html

jiggzson commented 4 years ago

I see. I guess that puts the undocumented argument to rest 😆. Well, feel free to send over a PR to help speed this issue up. If you decide to do so, thanks in advance. I've been somewhat short on time lately so it might take a little while before I get to it.

MarcusRiemer commented 3 years ago

Is there an ETA for the release containing https://github.com/jiggzson/nerdamer/commit/3435dd299b8797f69ecab7b0c413a98a4955b5cd? I just stumbled over the same thing and was about to add the type annotations when I recognized tat @jiggzson already did the deed. Thanks alot!

jiggzson commented 3 years ago

@MarcusRiemer,

I'd like to take care of two more bugs before releasing. In the meantime, if you see any other defs that are missing, please let me know.

jiggzson commented 3 years ago

@nishantwrp, fixed. @MarcusRiemer, published.