jigs5460 / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn
0 stars 0 forks source link

svn:global-ignores not used when adding #630

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
reported on the mailing list:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=30757
60

When adding a folder, all files in that unversioned folder are shown in the add 
dialog, and all files are checked by default.
Even files ignored via the svn:global-ignores property are shown.

We should read the svn:global-ignores property first and only show files which 
don't match that in the add dialog.

Original issue reported on code.google.com by tortoisesvn on 7 Apr 2014 at 6:06

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r25406.

Original comment by tortoisesvn on 7 Apr 2014 at 7:48

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r25407.

Original comment by tortoisesvn on 7 Apr 2014 at 7:49

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r25408.

Original comment by tortoisesvn on 7 Apr 2014 at 8:05

GoogleCodeExporter commented 9 years ago
Great update, thank you very much! I see this works for the svn:ignore property 
as well.
But wouldn't it be better still to offer the ignored files in the Add dialog, 
but to have them unchecked (and maybe sorted to the bottom of the list) by 
default? This would keep the workflow exactly identical in the standard case 
that the user wants the ignored files not to be added, but it would open the 
possibility to override this property for specific files. In the latter case, 
as it is now, the user has to add the files in question in a second step 
instead, which seems quite bulky to me.

Thanks for your consideration.

Douba

Original comment by Doub...@googlemail.com on 15 May 2014 at 11:51

GoogleCodeExporter commented 9 years ago
not really: showing ignored files in the add dialog would be wrong (that's why 
this issue exists: it is a bug). Because those files are explicitly ignored.

Original comment by tortoisesvn on 15 May 2014 at 5:03