search

jiixyj / epoll-shim

small epoll implementation using kqueue; includes all features needed for libinput/libevdev
MIT License
91 stars 24 forks source link

timerfd_gettime is not defined #12

Closed arrowd closed 4 years ago

arrowd commented 4 years ago

pipewire master branch started using timerfd_gettime function, which is #if 0ed for some reason. If it is hard to implement, can we at least provide a stub for it?

While there, timerfd.h is also not defining TFD_TIMER_CANCEL_ON_SET, which is used in timerfd_settime call.

jiixyj commented 4 years ago

I've stubbed out timerfd_gettime in the branch "12-timerfd-gettime". Hopefully that part of pipewire will compile now. It looks like nothing really uses this call, though. Same thing with TFD_TIMER_CANCEL_ON_SET. So maybe stubbing them out will be enough.

In any case, timerfd_gettime doesn't look too difficult to implement.

TFD_TIMER_CANCEL_ON_SET looks like a different beast...

arrowd commented 4 years ago

This allowed me to build pipewire master. Can't test it yet, though, but is compiles, at least.

jiixyj commented 4 years ago

I've merged the "12-timerfd-gettime" branch (stub implementation) into master. For the "real" implementation of timerfd_gettime I've opened issue https://github.com/jiixyj/epoll-shim/issues/13.