jiixyj / libebur128

A library implementing the EBU R128 loudness standard.
MIT License
402 stars 76 forks source link

pkg-config file is broken when CMAKE_INSTALL_LIBDIR is absolute #121

Open alexshpilkin opened 2 years ago

alexshpilkin commented 2 years ago

As per title: ebur128/libebur128.pc.cmake has

prefix=@CMAKE_INSTALL_PREFIX@
includedir=${prefix}/include
libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@

and so can’t handle an absolute path in CMAKE_INSTALL_LIBDIR. This leads to a broken .pc file on NixOS in particular.

Similar to https://github.com/open-source-parsers/jsoncpp/pull/1199. See “Concatenating paths when building pkg-config files” for a discussion of the problem and a suggested fix (I don’t know CMake myself, sorry).