search

jiixyj / libebur128

A library implementing the EBU R128 loudness standard.
MIT License
396 stars 76 forks source link

memory leak fix #30

Closed jonassmedegaard closed 10 years ago

jonassmedegaard commented 10 years ago

Hi,

It seems that the MLT project has spotted and fixed a memory leak in libebur128: https://github.com/mltframework/mlt/commit/9d35a6b

andrewrk commented 10 years ago

Nice find. I see that you reported this debian bug too: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762341

@jiixyj if you are having trouble finding time to review and merge this code, I would be happy to do it. Just add me as a collaborator on GitHub.

andrewrk commented 10 years ago

Fixed in 2ba9ff9f591388a3badd05c1e6da0a229eb6b847

jiixyj commented 10 years ago

Thanks for bringing this to my attention! I've incorporated this into a new bug fix release. Andrew, I've added you as a collaborator anyway, thanks for using and improving this code :)

jonassmedegaard commented 10 years ago

Quoting Andrew Kelley (2014-09-21 15:00:39)

Nice find. I see that you reported this debian bug too: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762341

Above referenced bug is related but on not linking against system shared code but embedding a local copy, which we try hard to avoid in Debian to ease security maintenance (and other reasons, like memory use).

I did raise this issue in Debian, although not as a bugreport but here: https://lists.alioth.debian.org/pipermail/secure-testing-team/2014-September/006461.html

jonassmedegaard commented 10 years ago

Quoting jiixyj (2014-09-21 16:46:43)

Thanks for bringing this to my attention! I've incorporated this into a new bug fix release. Andrew, I've added you as a collaborator anyway, thanks for using and improving this code :)

Wauw - that was quick!

I have made the maintainers of libebur128 in Debian aware of this new release.

Thanks!

andrewrk commented 10 years ago

I am the maintainer of the Debian package - I'll get this new version uploaded soon :)

jonassmedegaard commented 10 years ago

Quoting Andrew Kelley (2014-09-21 21:46:57)

I am the maintainer of the Debian package - I'll get this new version uploaded soon :)

Ohh - that explains why your name looked familiar :-D

Breeder commented 9 years ago

Thanks for the fix, updated SWS accordingly :)