search

jiixyj / libebur128

A library implementing the EBU R128 loudness standard.
MIT License
402 stars 76 forks source link

Intermittently strange result with very large true peak #72

Closed jherby2k closed 6 years ago

jherby2k commented 6 years ago

In my app's test suite I occasionally get a true peak like 2.1267647932558654E+38, which is obviously not correct (should be 1.014152). Doesn't happen with sample peaks, and like I said it is intermittent (about 1 time in 20).

I don't believe its a race condition or anything as this is an "album" with only 1 track, and my tests do not run in parallel.

I've seen it with 44.1 kHz, 48 kHz and 96 kHz versions of the same file.

jiixyj commented 6 years ago

Thanks for the report! I could reproduce it doing a complete true peak scan of my music library. I think I fixed it in 2177c23cc74a8bdc8d088313b4d90f422d20d4aa. Doing another scan right now.

jherby2k commented 6 years ago

Thanks for your prompt reply! My tests are all passing now reliably. Do you think this warrants a 1.2.3 release?

jiixyj commented 6 years ago

Yeah, I think a 1.2.3 with this fixed would be appropriate.

jiixyj commented 6 years ago

Thank you for testing the fix!