"make install" only install libebur128

[domichel]

On my gentoo amd64 system, the build succed, but "make install only install libebur128:

I made a live ebuild in order to incorporate it with portage. The installation phase is:

>>> Install loudness-9999 into /var/tmp/portage/media-sound/loudness-9999/image/ category media-sound
>>> Working in BUILD_DIR: "/var/tmp/portage/media-sound/loudness-9999/work/loudness-9999_build"
make -j3 install 
[  5%] Built target ebur128_static
[ 10%] Built target ebur128
[ 16%] Built target filetree
[ 21%] Built target input_mpg123
[ 27%] Built target input
[ 35%] Built target input_sndfile
[ 40%] Built target input_musepack
[ 45%] Built target input_gstreamer
[ 54%] Built target input_ffmpeg
[ 64%] Built target scanner-common
[ 72%] Built target scanner-lib
[ 81%] Built target scanner-tag
[ 86%] Built target loudness
[ 91%] Built target loudness-drop-gtk
[100%] Built target loudness-drop-qt
Install the project...
-- Install configuration: "Gentoo"
-- Installing: /var/tmp/portage/media-sound/loudness-9999/image/usr/include/ebur128.h
-- Installing: /var/tmp/portage/media-sound/loudness-9999/image/usr/lib/libebur128.so.1.0.1
-- Installing: /var/tmp/portage/media-sound/loudness-9999/image/usr/lib/libebur128.so.1
-- Installing: /var/tmp/portage/media-sound/loudness-9999/image/usr/lib/libebur128.so
-- Installing: /var/tmp/portage/media-sound/loudness-9999/image/usr/lib/libebur128.a
>>> Completed installing loudness-9999 into /var/tmp/portage/media-sound/loudness-9999/image/

 * Final size of build directory: 3928 KiB
 * Final size of installed tree: 76 KiB

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * /var/tmp/portage/media-sound/loudness-9999/work/loudness-9999/scanner/scanner-common/scanner-common.c:350:36: warning: implicit declaration of function ‘nproc’ [-Wimplicit-function-declaration]

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: https://github.com/jiixyj/loudness-scanner
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   usr/lib/libebur128.so.1.0.1
   usr/lib/libebur128.a
ecompressdir: bzip2 -9 /usr/share/doc

>>> Installing (1 of 1) media-sound/loudness-9999::test
 * checking 7 files for package collisions
>>> Merging media-sound/loudness-9999 to /
--- /usr/
--- /usr/include/
>>> /usr/include/ebur128.h
--- /usr/lib/
>>> /usr/lib/libebur128.a
>>> /usr/lib/libebur128.so.1.0.1
--- /usr/share/
--- /usr/share/doc/
--- /usr/share/doc/loudness-9999/
>>> /usr/share/doc/loudness-9999/TODO.bz2
>>> /usr/share/doc/loudness-9999/README.md.bz2
>>> /usr/lib/libebur128.so.1 -> libebur128.so.1.0.1
>>> /usr/lib/libebur128.so -> libebur128.so.1

We can see that the plugins and the software is build, but they are not installed. Also, the QA notice may be of interest.

Best, Dominique

[domichel]

With this pull request https://github.com/jiixyj/loudness-scanner/pull/8 it install the following files:

--- /usr/
--- /usr/include/
>>> /usr/include/ebur128.h
--- /usr/lib/
>>> /usr/lib/libebur128.so.1 -> libebur128.so.1.0.1
>>> /usr/lib/libebur128.so -> libebur128.so.1
>>> /usr/lib/libebur128.a
>>> /usr/lib/libscanner-lib.a
>>> /usr/lib/libebur128.so.1.0.1
>>> /usr/lib/libinput.a
>>> /usr/lib/libinput_sndfile.so
>>> /usr/lib/libinput_mpg123.so
>>> /usr/lib/libinput_ffmpeg.so
>>> /usr/lib/libscanner-common.a
>>> /usr/lib/libinput_gstreamer.so
>>> /usr/lib/libscanner-tag.a
--- /usr/bin/
>>> /usr/bin/loudness
>>> /usr/bin/loudness-drop-gtk
>>> /usr/bin/loudness-drop-qt
--- /usr/share/
--- /usr/share/doc/
--- /usr/share/doc/loudness-9999/
>>> /usr/share/doc/loudness-9999/TODO.bz2
>>> /usr/share/doc/loudness-9999/README.md.bz2

[valpackett]

Looks like that PR is out of date, and it didn't solve plugin search. (And installed static libraries no one needs.)

Plugins should be installed into a subdirectory of PREFIX/lib and searched for there:

--- scanner/inputaudio/CMakeLists.txt.orig      2019-06-14 18:58:09 UTC
+++ scanner/inputaudio/CMakeLists.txt
@@ -20,5 +20,8 @@ if(GMODULE20_FOUND AND NOT DISABLE_GLIB20)

   add_library(input input)

+  set_property(TARGET input APPEND PROPERTY
+    COMPILE_DEFINITIONS "INPUT_PREFIX=\"${CMAKE_INSTALL_PREFIX}\"")
+
   target_link_libraries(input ${GMODULE20_LIBRARIES})
 endif()
--- scanner/inputaudio/input.c.orig     2018-07-01 10:28:47 UTC
+++ scanner/inputaudio/input.c
@@ -21,6 +21,7 @@ static const char* plugin_search_dirs[] = {
   "r128",
   "",
   NULL, /* = g_path_get_dirname(av0); */
+  INPUT_PREFIX "/lib/loudness",
   NULL
 };

--- scanner/CMakeLists.txt.orig 2018-07-01 10:28:47 UTC
+++ scanner/CMakeLists.txt
@@ -47,6 +47,7 @@ if(GLIB20_FOUND AND GTHREAD20_FOUND AND NOT DISABLE_GL
   target_link_libraries(loudness
         scanner-lib filetree input
         ${GLIB20_LIBRARIES} ${GTHREAD20_LIBRARIES})
+  install(TARGETS loudness DESTINATION bin)

--- scanner/inputaudio/ffmpeg/CMakeLists.txt.orig       2019-06-14 18:36:05 UTC
+++ scanner/inputaudio/ffmpeg/CMakeLists.txt
@@ -47,4 +47,6 @@ if(LIBAVFORMAT_FOUND AND GMODULE20_FOUND AND
     set_target_properties(input_ffmpeg PROPERTIES
                LINK_FLAGS ${INPUT_FFMPEG_LDFLAGS})
   endif()
+
+  install(TARGETS input_ffmpeg DESTINATION lib/loudness)
 endif()
--- scanner/inputaudio/mpcdec/CMakeLists.txt.orig       2019-06-14 18:36:31 UTC
+++ scanner/inputaudio/mpcdec/CMakeLists.txt
@@ -27,4 +27,6 @@ if(GMODULE20_FOUND AND MPCDEC_FOUND AND
   set_target_properties(input_musepack PROPERTIES
           COMPILE_FLAGS ${INPUT_MPCDEC_CFLAGS}
              LINK_FLAGS ${INPUT_MPCDEC_LDFLAGS})
+
+  install(TARGETS input_musepack DESTINATION lib/loudness)
 endif()
--- scanner/inputaudio/mpg123/CMakeLists.txt.orig       2019-06-14 18:35:59 UTC
+++ scanner/inputaudio/mpg123/CMakeLists.txt
@@ -27,4 +27,6 @@ if(GMODULE20_FOUND AND MPG123_FOUND AND
   set_target_properties(input_mpg123 PROPERTIES
           COMPILE_FLAGS ${INPUT_MPG123_CFLAGS}
              LINK_FLAGS ${INPUT_MPG123_LDFLAGS})
+
+  install(TARGETS input_mpg123 DESTINATION lib/loudness)
 endif()
--- scanner/inputaudio/sndfile/CMakeLists.txt.orig      2019-06-14 18:37:36 UTC
+++ scanner/inputaudio/sndfile/CMakeLists.txt
@@ -32,4 +32,6 @@ if(GMODULE20_FOUND AND SNDFILE_FOUND AND
     set_target_properties(input_sndfile PROPERTIES
                LINK_FLAGS ${INPUT_SNDFILE_LDFLAGS})
   endif()
+
+  install(TARGETS input_sndfile DESTINATION lib/loudness)
 endif()

(doesn't include gstreamer because I don't want anything to use the ancient gstreamer 0.1)