Method UploadServlet.copyFromInputStreamToOutputStream is not safe

[GoogleCodeExporter]

This method does not flush the output buffer properly when exception occurs.

It should be done in finally block.

I would prefer to use utility method from commons io rather than using own 
implementation.

Anyway thanks for the library, its nice.

Original issue reported on code.google.com by lukas.zapletal on 2 Aug 2010 at 11:29

[GoogleCodeExporter]

Original comment by manuel.carrasco.m on 3 Aug 2010 at 5:55

• Changed state: Accepted

[GoogleCodeExporter]

This issue was closed by revision r795.

Original comment by manuel.carrasco.m on 3 Aug 2010 at 6:53

• Changed state: Fixed

[GoogleCodeExporter]

Good point, although gwtupload depends on commons-io because of the transitive 
dependency in commons-fileupload, I didn't know these methods in IOUtils, thank 
you for reporting.

-Manolo

Original comment by manuel.carrasco.m on 3 Aug 2010 at 6:55

[GoogleCodeExporter]

Yup there are very nice helper methods there. Thx for the library ;-)

Original comment by lukas.zapletal on 3 Aug 2010 at 6:58