jijo-paulose / node-xmpp-bosh

Automatically exported from code.google.com/p/node-xmpp-bosh
0 stars 0 forks source link

Simplify packet processing when an XML stanza is received from the XMPP server #23

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently, the packet processing and enqueuing logic is unnecessarily 
complicated (and wasteful of responses in some cases).

Simplify this processing so that:

* No logic is required to merge XML responses - this should be as simple as 
appending to an array rather than comparing object attributes and values like 
it currently is now.

* There are 2 buffers maintained, one for XMPP stanza responses and one for 
BOSH responses (attributed and response type mainly). When the response is 
about to be sent, stitch the response at the absolute last minute so that we 
can now send terminate stanzas that contain XMPP XML stanzas too (currently, 
this doesn't happen and rarely results in some funny cases).

Original issue reported on code.google.com by dhruvb...@gmail.com on 11 Sep 2011 at 12:31

GoogleCodeExporter commented 9 years ago

Original comment by dhruvb...@gmail.com on 14 Oct 2011 at 1:32

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r472.

Original comment by satyamsh...@gmail.com on 6 Dec 2011 at 9:31