jikan-me / jikan-rest

The REST API for Jikan
https://docs.api.jikan.moe/
MIT License
435 stars 270 forks source link

🐛 Searching for "Ninjala" returns results for "Ninja" #401

Closed Prid13 closed 1 year ago

Prid13 commented 1 year ago

Is there an existing issue for this?

Current Behavior

Searching for "Ninjala" and "Ninja" returns the same results: https://api.jikan.moe/v4/anime?q=ninjala&sfw

Naruto and other ninja animes show up:

image

Expected Behavior

The Ninjala anime is supposed to be returned, along with its related series (ONA episodes)

Steps To Reproduce

No response

Environment

No response

Anything else?

If I try searching for "Ninjalala", the correct anime shows up among others. But if I try "Nijala" (missing n), only the correct animes show up:

image

pushrbx commented 1 year ago

@Prid13 which one should be the first hit? Ninjala TV or the Ninjala ONA?

Prid13 commented 1 year ago

@pushrbx personally I would expect Ninjala TV since it's a full-fledged anime with 20-minute episodes and ongoing with 70+ episodes, while the ONA was a promo tie-in for the game of the same name (despite airing first).

But honestly it doesn't really matter which is first. The main issue was not getting any relevant searches when searching for "Ninjala" 😅

pushrbx commented 1 year ago

@pushrbx personally I would expect Ninjala TV since it's a full-fledged anime with 20-minute episodes and ongoing with 70+ episodes, while the ONA was a promo tie-in for the game of the same name (despite airing first).

But honestly it doesn't really matter which is first. The main issue was not getting any relevant searches when searching for "Ninjala" 😅

I should have said that I fixed this issue on my end today and I wanted to have a more accurate acceptance criteria to sign this off.

Prid13 commented 1 year ago

@pushrbx sorry, my bad 😅 Ninjala TV should be first in my personal opinion (I have not watched these animes).

Prid13 commented 1 year ago

@pushrbx not sure if you've only fixed this one edge case or most edge cases with similar "issues", because I found another one. Try searching for "persona". Literally everything other than the Persona series show up 😅

If I add a number after the keyword, the correct entries show up, e.g. "Persona 5".

But like Ninjala, if you remove any one letter, like "prsona", you get the correct results:

image

pushrbx commented 1 year ago

On my end with the fixes im working on: currently if I look for "Persona" it works as expected. However with "prsona" I get nothing, which is a bit odd... Because that means that the typo correction doesn't work with that term for some reason.

pushrbx commented 1 year ago

Somewhat fixed in #409 , however it's not yet deployed to prod.

irfan-dahir commented 1 year ago

Resolved

Wamy-Dev commented 1 year ago

can we please reopen? Search terms such as "Girls & Panzer" do not show up with the correct searching

Prid13 commented 1 year ago

However with "prsona" I get nothing, which is a bit odd... Because that means that the typo correction doesn't work with that term for some reason.

"prsona" still isn't working in the new version 😅 otoh, "perona" works.

Thanks for all the hard work btw, immensely appreciate it ⭐

pushrbx commented 1 year ago

However with "prsona" I get nothing, which is a bit odd... Because that means that the typo correction doesn't work with that term for some reason.

"prsona" still isn't working in the new version sweat_smile otoh, "perona" works.

Thanks for all the hard work btw, immensely appreciate it star

prsona will not work, that's entirely a question for typesense dev team, I don't think we can fix it on our end until we understand how we can tune typesense for anime/manga titles. :smile_cat: