Open pushrbx opened 8 months ago
The getSeasonRange should be inside the DefaultAnimeRepository class, and the signature of the getAiredBetween should be getAiredBetween($year, $season, $type) or we should create a getBySeason($year, $season, $type) function.
getSeasonRange
DefaultAnimeRepository
getAiredBetween
getAiredBetween($year, $season, $type)
getBySeason($year, $season, $type)
_Originally posted by @pushrbx in https://github.com/jikan-me/jikan-rest/pull/448#discussion_r1372262225_
The
getSeasonRange
should be inside theDefaultAnimeRepository
class, and the signature of thegetAiredBetween
should begetAiredBetween($year, $season, $type)
or we should create agetBySeason($year, $season, $type)
function._Originally posted by @pushrbx in https://github.com/jikan-me/jikan-rest/pull/448#discussion_r1372262225_