search

jikan-me / jikan-rest

The REST API for Jikan
https://docs.api.jikan.moe/
MIT License
413 stars 268 forks source link

Add annotations to the manifest during container building in github actions #458

Open pushrbx opened 7 months ago

pushrbx commented 7 months ago

There is a new version of docker/build-push-action which allows adding annotations. This will fix the blank package information sections on the packages page at https://github.com/jikan-me/jikan-rest/pkgs/container/jikan-rest/144357164?tag=v4.1.1

The github action to deploy containers should be modified to add the annotations.

New version: https://github.com/docker/build-push-action/releases/tag/v5.1.0

pushrbx commented 5 months ago

That change didn't work, because I didn't know that the annotations should be "index" level not "manifest" level (which is the default).

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#labelling-container-images

Reopening this issue.