jikan-me / jikan-rest

The REST API for Jikan
https://docs.api.jikan.moe/
MIT License
413 stars 268 forks source link

Changed cache scope for container image build #459

Closed pushrbx closed 6 months ago

pushrbx commented 7 months ago

Fixes #457

I'm not entirely sure if this is going to be the best way to do it, but it worth a shot. The idea here is to have one set of cache elements per matrix build. If we consider the way docker uses cached layers during build, there might no need to include the branch and tag name in the scope value:

  1. docker builds the first few layers, which in case of jikan api the php extensions, composer dependencies, and roadrunner.
  2. then it takes the files of jikan and adds it to the image

Because of step one is being constant most of the time, it should work with just the cpu arch as a cache key.