search

jikan-me / jikan-rest

The REST API for Jikan
https://docs.api.jikan.moe/
MIT License
413 stars 268 forks source link

✅ Fixed sort index issue with typesense indexing #491

Closed pushrbx closed 5 months ago

pushrbx commented 5 months ago

All models have a "title" field, and that's the default sorting field, however this is not being indexed as such for the models, except where explicitly specified (Anime and Manga models)

Fixes #488

Please note that after this change all of those who are self hosting need to reindex everything in typesense via:

php artisan scout:flush App\\Character
php artisan scount:import App\\Character

Plus the other models: Anime, Manga, Person, Club, Profile, GenreAnime, GenreManga

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (02613f5) 56.92% compared to head (f590e29) 57.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #491 +/- ## ============================================ + Coverage 56.92% 57.18% +0.26% - Complexity 1351 1352 +1 ============================================ Files 339 339 Lines 5444 5454 +10 ============================================ + Hits 3099 3119 +20 + Misses 2345 2335 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.