jikan-me / jikan-rest

The REST API for Jikan
https://docs.api.jikan.moe/
MIT License
428 stars 270 forks source link

🐛 API Returns Empty Response When 'score' and 'producers' Parameters are Used Together #517

Closed mirzaahmedov closed 4 months ago

mirzaahmedov commented 7 months ago

Is there an existing issue for this?

Current Behavior

The API returns an empty response when both the 'score' and 'producers' query parameters are included in the request.

Expected Behavior

The API should return a response containing relevant data, filtered based on the provided 'score' and 'producers' query parameters.

Steps To Reproduce

Make a request to the API endpoint with both the 'score' and 'producers' query parameters set. Observe that the API response is empty.

Environment

- OS: Linux
- Browser: Brave

Anything else?

API Endpoint: https://api.jikan.moe/v4/anime Query Parameters: score: 8 producers: 11 Example Request: https://api.jikan.moe/v4/anime?score=8&producers=11

screenshot

irfan-dahir commented 7 months ago

Good catch. Meanwhile, a working alternative would be this: https://api.jikan.moe/v4/anime?min_score=8&producers=11

pushrbx commented 7 months ago

Possible cause: we use $query->whereRaw() for the producers filter, which obliterates other calls to the query builder.