jikan-me / jikan-rest

The REST API for Jikan
https://docs.api.jikan.moe/
MIT License
413 stars 268 forks source link

✅ Fixed a bug around season endpoints #527

Closed pushrbx closed 1 week ago

pushrbx commented 2 months ago

Fixes #521

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (7dd9625) to head (cc38196).

Files Patch % Lines
app/Features/QueryCurrentAnimeSeasonHandler.php 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #527 +/- ## ============================================ + Coverage 57.76% 58.04% +0.27% Complexity 1352 1352 ============================================ Files 339 339 Lines 5209 5236 +27 ============================================ + Hits 3009 3039 +30 + Misses 2200 2197 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pushrbx commented 1 month ago

There is another bug in the test system, which makes the tests flaky. :tired_face:

pushrbx commented 1 month ago

I've added some seeding based on the job id if the test is being ran in a github action runner. Also I've tweaked the factories:

pushrbx commented 2 weeks ago

This is still not good. I just tested this, and Kaiju No 8 comes up in the summer season as left over, but it's finishing on the 28th of June.

pushrbx commented 2 weeks ago

Now it will work reliably. However I've introduced a hard requirement on mongodb version 5 or higher.