search

jillesvangurp / kt-search

Multi platform kotlin client for Elasticsearch & Opensearch with easily extendable Kotlin DSLs for queries, mappings, bulk, and more.
MIT License
95 stars 23 forks source link

[FEAT] Configure a client without a port #70

Closed legzo closed 1 year ago

legzo commented 1 year ago

Describe the enhancement

I would like to be able to specify a connection URL without a port.

Why is this needed?

My ES cluster has a proxy in front of it and the API responds when no port is specified but does not responds if I specify 80 as port. So, right now, I can't use kt-search at all (unless I missed something in the docs, but I checked the code and it seems that port is non nullable in Node so....)

Will you be able to help with a pull request?

I sure can. Maybe it is possible to just make port nullable in Node data class, but it may have implications that I don't suspect... :)

Cheers

jillesvangurp commented 1 year ago

Good suggestion. Doing a quick fix for this.